<div dir="ltr">thanks for the update, Shlomo.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 9, 2018 at 12:40 PM, Shlomo Solomon <span dir="ltr"><<a href="mailto:shlomo.solomon@gmail.com" target="_blank">shlomo.solomon@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Shlomi,<br>
Thanks for your feedback - my reply below.<br>
<span class=""><br>
On Tue, 9 Jan 2018 12:21:51 +0200<br>
Shlomi Fish <<a href="mailto:shlomif@gmail.com">shlomif@gmail.com</a>> wrote:<br>
<br>
> Hi Shlomo,<br>
><br>
> On Tue, Jan 9, 2018 at 10:36 AM, Shlomo Solomon<br>
> <<a href="mailto:shlomo.solomon@gmail.com">shlomo.solomon@gmail.com</a>> wrote:<br>
><br>
> > Since import msvcrt in Python is Windows specific, I adapted some<br>
> > code I found to provide kbhit() and getch() in Python under Linux.<br>
> ><br>
> > I'm attaching KBHIT.py which replaces msvcrt and a small program to<br>
> > demonstrate how to use it - KBHIT-test.py.<br>
> ><br>
> > The KBHIT.py documentation includes usage instructions and also a<br>
> > link to the code I borrowed and (I hope) improved.<br>
> ><br>
> ><br>
> thanks for your contribution.<br>
><br>
> some comments:<br>
><br>
> 1. What is the licence of the code? See<br>
> <a href="https://www.mail-archive.com/perl6-users@perl.org/msg04541.html" rel="noreferrer" target="_blank">https://www.mail-archive.com/<wbr>perl6-users@perl.org/msg04541.<wbr>html</a> .<br>
<br>
</span>Note the following statement in the code (was already in the code I<br>
"borrowed" and I felt it would be wrong/dis-honest to change it):<br>
This program is free software: you can redistribute it and/or modify<br>
it under the terms of the GNU Lesser General Public License as<br>
published by the Free Software Foundation, either version 3 of the<br>
License, or (at your option) any later version.<br>
<span class=""><br>
><br>
> 2. Please use a PyPI-like distribution format, see<br>
> <a href="https://github.com/ofek/hatch" rel="noreferrer" target="_blank">https://github.com/ofek/hatch</a> or<br>
> <a href="https://github.com/audreyr/cookiecutter-pypackage" rel="noreferrer" target="_blank">https://github.com/audreyr/<wbr>cookiecutter-pypackage</a> .<br>
<br>
</span>You're probably right, but since this was just something I hacked<br>
together to solve a specific problem I was having, I didn't really see<br>
the need to "formalize" it.<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> 3. For more best practices, see<br>
> <a href="https://github.com/shlomif/Freenode-programming-channel-FAQ/blob/master/FAQ.mdwn#what-are-some-best-practices-in-programming-that-i-should-adopt" rel="noreferrer" target="_blank">https://github.com/shlomif/<wbr>Freenode-programming-channel-<wbr>FAQ/blob/master/FAQ.mdwn#what-<wbr>are-some-best-practices-in-<wbr>programming-that-i-should-<wbr>adopt</a><br>
> .<br>
><br>
> 4. -test.py should be -example.py<br>
><br>
><br>
> ><br>
> > --<br>
> > Shlomo Solomon<br>
> > <a href="http://the-solomons.net" rel="noreferrer" target="_blank">http://the-solomons.net</a><br>
> > Claws Mail 3.11.1 - KDE 4.14.30 - Dolphin 4.14.3 - LINUX Mageia 5<br>
> > ______________________________<wbr>_________________<br>
> > Linux-il mailing list<br>
> > <a href="mailto:Linux-il@cs.huji.ac.il">Linux-il@cs.huji.ac.il</a><br>
> > <a href="http://mailman.cs.huji.ac.il/mailman/listinfo/linux-il" rel="noreferrer" target="_blank">http://mailman.cs.huji.ac.il/<wbr>mailman/listinfo/linux-il</a><br>
> ><br>
> ><br>
><br>
><br>
<br>
<br>
<br>
--<br>
Shlomo Solomon<br>
<a href="http://the-solomons.net" rel="noreferrer" target="_blank">http://the-solomons.net</a><br>
Claws Mail 3.11.1 - KDE 4.14.30 - Dolphin 4.14.3 - LINUX Mageia 5<br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr">Shlomi Fish <a href="http://www.shlomifish.org/" target="_blank">http://www.shlomifish.org/</a><br><br>You can never truly appreciate The Gilmore Girls until you've watched it in the original Klingon.<br><br>Please reply to list if it's a mailing list post - <a href="http://shlom.in/reply" target="_blank">http://shlom.in/reply</a> .<br></div></div></div></div>
</div>